Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ciao: init at 1.19.0 #85986

Merged
merged 1 commit into from May 27, 2020
Merged

ciao: init at 1.19.0 #85986

merged 1 commit into from May 27, 2020

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Apr 25, 2020

Motivation for this change

Fixes #85081.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

puzzlewolf
puzzlewolf suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and the hello world example works :)

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on Nixos x86-64
  • executables tested on Nixos x86-64 (ran each executable with --help, they all either printed help info or complained of not understanding the flag :D)
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • source is fetched using the appropriate function
  • phases are respected

pkgs/development/compilers/ciao/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/ciao/default.nix Outdated Show resolved Hide resolved
@suhr suhr force-pushed the ciao branch 2 times, most recently from 3123cc3 to 55da2b6 Compare May 20, 2020 17:06
puzzlewolf
puzzlewolf approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/162

@AndersonTorres AndersonTorres merged commit 24f9bc0 into NixOS:master May 27, 2020
@suhr suhr deleted the ciao branch May 27, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ciao programming language
4 participants
@suhr @nixos-discourse @puzzlewolf @AndersonTorres