Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipewire: patch for SIGILL in fmt-ops #85985

Merged
merged 1 commit into from Apr 25, 2020
Merged

pipewire: patch for SIGILL in fmt-ops #85985

merged 1 commit into from Apr 25, 2020

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Apr 25, 2020 •
edited

Motivation for this change

Hydra run tests are failing with SIGILL, see 1 , import the upstream
patch to fix the issue. Presumably not all hydra runners have the same
instruction extensions, this should fix the tests on those without AVX2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
pipewire: patch for SIGILL in fmt-ops
bc8e1f3 
Hydra run tests are failing with SIGILL, see [1] , import the upstream
patch to fix the issue. Presumably not all hydra runners have the same
instruction extensions, this should fix the tests on those without AVX2.

[1]: https://hydra.nixos.org/build/117012754
@Mic92
Copy link
Member

Mic92 commented Apr 25, 2020

@GrahamcOfBorg build pipewire

@ofborg ofborg bot requested a review from jtojnar April 25, 2020 06:38
@jtojnar jtojnar merged commit 2dee6ad into NixOS:master Apr 25, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Apr 25, 2020

Thank you.

@Emantor Emantor deleted the fix/pipewire branch July 3, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Emantor @Mic92 @jtojnar