Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] Gnome 3.34 updates #85974

Closed

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I have:

  • ran update.nix
  • excluded updates that didn't make sense
  • did one's outside the version bound that did make sense (folks for example)
  • did backports from master where possible

I haven't built anything, not sure if I should split this into a staging-20.03 PR and a release-20.03 PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

I actually think it would be best to target staging-20.03 so we can run an eval, and in the small chance something does break, we'll see it.

@worldofpeace worldofpeace changed the base branch from release-20.03 to staging-20.03 April 25, 2020 00:44
@worldofpeace worldofpeace changed the base branch from staging-20.03 to release-20.03 April 25, 2020 00:45
@worldofpeace worldofpeace changed the base branch from release-20.03 to staging-20.03 April 25, 2020 00:45
@worldofpeace
Copy link
Contributor Author

I've built select packages to find out what didn't work. Will build more today.

@FRidh FRidh moved this from Done to WIP in Staging (stable) Apr 27, 2020
@worldofpeace worldofpeace added this to In progress in Pantheon via automation Apr 28, 2020
@worldofpeace worldofpeace added this to In Progress in GNOME Apr 28, 2020
@worldofpeace worldofpeace removed this from In progress in Pantheon Apr 28, 2020
@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label May 11, 2020
@vcunat
Copy link
Member

vcunat commented Jun 22, 2020

Thank you for your contributions.
This has been automatically marked as stale... I mean, what's up with this? I agree that minor number bumps generally can be pushed to stable releases, so the problem here is only that noone here has tested these particular versions yet?

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jun 22, 2020

@vcunat Thanks for checking in, yeah, I think I opened this PR probably right before my vacation
so I couldn't test it myself. And I believe it was a bit too much for @jtojnar to test since he doesn't use the stable releases.
If we can get it in staging and I can try it out, it should be fine 🤞 Not sure if more minor updates have been made, though, making this stale.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 22, 2020

Yeah, there has been 3.34.6 and 3.34.7 in the meanwhile.

@worldofpeace
Copy link
Contributor Author

we're doing #93114 now

Staging (stable) automation moved this from WIP to Done Jul 14, 2020
@worldofpeace worldofpeace deleted the gnome-3.34-updates branch July 14, 2020 13:00
@worldofpeace worldofpeace moved this from In Progress to Done in GNOME Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
GNOME
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants