Use rsync instead of scp for file copying #1323
Conversation
adisbladis
force-pushed
the
scp-to-rsync
branch
from
b626820
to
1e43587
Compare
|
I cannot find a reference now, but I distinctly recall the openssh devs mentioning that scp was supported for legacy reasons, and not really recommended. It was during the discussion of CVE-2018-20685. |
This will allow us to pass options to openssh and escalate privileges (see NixOS#1270) more easily. Closes NixOS#1322
| @@ -419,27 +419,35 @@ def copy_closure_to(self, path): | |||
| env=env, | |||
| ) | |||
|
|
|||
| def get_scp_name(self): | |||
| def _get_scp_name(self) -> str: | |||
There was a problem hiding this comment.
double-checked that this wasn't used in plugins. I probably wasn't conclusive, but I checked at least GCE, AWS, and nix-community's plugins.
|
Just looking at the semantics of the trailing slash in rsync's manpage:
scp's manpage:
I think we're good on this front. |
|
I gave this a try on my network and it worked well. I added new keys and did a send-keys, which also worked. Notes:
|
This will allow us to pass options to openssh and escalate privileges (see #1270) more easily.
Closes #1322