Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] coreutils: 8.31 -> 8.32 #85953

Closed
wants to merge 1 commit into from
Closed

[WIP] coreutils: 8.31 -> 8.32 #85953

wants to merge 1 commit into from

Conversation

lovesegfault
Copy link
Member

Motivation for this change

While working on #85951 I noticed this was out-of-date.

cc. @FRidh for inclusion in staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra April 24, 2020 19:22
@veprbl veprbl added this to WIP in Staging via automation Apr 24, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Apr 24, 2020
@lovesegfault lovesegfault force-pushed the coreutils-8.32 branch 3 times, most recently from 51fa4f0 to fddd45b Compare April 27, 2020 17:10
@FRidh FRidh added this to the 20.09 milestone Apr 27, 2020
@FRidh
Copy link
Member

FRidh commented Apr 27, 2020

aarch64 failure

@lovesegfault
Copy link
Member Author

aarch64 failure

Fix incoming

@lovesegfault
Copy link
Member Author

Alright fixed the issues on AArch64, also re-enabled parallel building as the noted issue for having it disabled is no longer reproducible.

cc. @FRidh

@veprbl
Copy link
Member

veprbl commented Apr 28, 2020

@GrahamcOfBorg build coreutils pkgsMusl.coreutils

@veprbl
Copy link
Member

veprbl commented Apr 28, 2020

@GrahamcOfBorg build coreutils
@GrahamcOfBorg build pkgsMusl.coreutils
@GrahamcOfBorg build pkgsi686Linux.coreutils

@veprbl
Copy link
Member

veprbl commented Apr 28, 2020

cc @bkchr as author of 320a4c1

@lovesegfault
Copy link
Member Author

I'm working on this some more

@veprbl veprbl changed the title coreutils: 8.31 -> 8.32 [WIP] coreutils: 8.31 -> 8.32 Apr 29, 2020
@veprbl veprbl moved this from Needs review to WIP in Staging May 1, 2020
Staging automation moved this from WIP to Done Jun 30, 2020
@lovesegfault lovesegfault deleted the coreutils-8.32 branch June 30, 2020 18:55
@veprbl veprbl removed this from Done in Staging Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @FRidh @veprbl