Skip to content

llvm_10: link to the llvm compiler-rt share directory from the wrapper #85925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2020
Merged

llvm_10: link to the llvm compiler-rt share directory from the wrapper #85925

merged 1 commit into from
Oct 11, 2020
+1 −0

Conversation

andir
Copy link
Member

@andir andir commented Apr 24, 2020 •
edited
Loading

Motivation for this change

This is required for features such as -fsanitze=cfi that (by default)
load the file …/resource-root/share/cfi_blacklist.txt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@andir
llvm_10: link to the llvm compiler-rt share directory from the wrapper

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
GPG key ID: E432E410B5E48C86
Expired
Verified
Learn about vigilant mode
d17650b 
This is required for features such as `-fsanitze=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.
@andir andir requested a review from matthewbauer as a code owner April 24, 2020 09:24
@Mic92 Mic92 requested a review from dtzWill April 24, 2020 11:13
@TredwellGit TredwellGit mentioned this pull request Oct 11, 2020
Merged
4 tasks
primeos
primeos approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@primeos primeos merged commit 3568e17 into NixOS:master Oct 11, 2020
primeos pushed a commit that referenced this pull request Oct 11, 2020
@TredwellGit
llvm_11: link to the llvm compiler-rt share directory from the wrapper (

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
03dd1b3 
#100190)

A port of #85925 for LLVM 11 to enable CFI for Chromium.

This is required for features such as `-fsanitize=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.
primeos pushed a commit to primeos/nixpkgs that referenced this pull request Nov 4, 2020
@TredwellGit @primeos
llvm_11: link to the llvm compiler-rt share directory from the wrapper (

Verified

This commit was signed with the committer’s verified signature.
primeos Michael Weiss
GPG key ID: 5BE487C4D4771D83
Verified
Learn about vigilant mode
49ebef3 
NixOS#100190)

A port of NixOS#85925 for LLVM 11 to enable CFI for Chromium.

This is required for features such as `-fsanitize=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.

(cherry picked from commit 03dd1b3)
rvem pushed a commit to serokell/nixpkgs that referenced this pull request Nov 8, 2022
@TredwellGit @rvem
llvm_11: link to the llvm compiler-rt share directory from the wrapper (

Verified

This commit was signed with the committer’s verified signature.
rvem Roman Melnikov
GPG key ID: 8931E8ED1EE2E537
Verified
Learn about vigilant mode
8303cc3 
NixOS#100190)

A port of NixOS#85925 for LLVM 11 to enable CFI for Chromium.

This is required for features such as `-fsanitize=cfi` that (by default)
load the file `…/resource-root/share/cfi_blacklist.txt`.

(cherry picked from commit 03dd1b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos

@matthewbauer matthewbauer

@dtzWill dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @primeos