Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chocolate-doom: 2.3.0 -> 3.0.0 #85917

Merged
merged 1 commit into from Apr 25, 2020
Merged

chocolate-doom: 2.3.0 -> 3.0.0 #85917

merged 1 commit into from Apr 25, 2020

Conversation

AXDOOMER
Copy link
Contributor

@AXDOOMER AXDOOMER commented Apr 24, 2020 •
edited

Motivation for this change

I've updated Chocolate-Doom as it has not been updated for a while. Chocolate-Doom 3.0 now uses SDL2 instead of the original SDL.

Chocolate-Doom has the same build system as Crispy-Doom, so the configuration file was modified to reflect what can be seen in crispy-doom's config file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from MP2E April 24, 2020 06:55
@AXDOOMER
Copy link
Contributor Author

AXDOOMER commented Apr 25, 2020 •
edited

The setup utility and the game both run once built.
image
image

MP2E
MP2E approved these changes Apr 25, 2020
View reviewed changes
Copy link

@MP2E MP2E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MP2E MP2E merged commit 134f200 into NixOS:master Apr 25, 2020
@MP2E
Copy link

MP2E commented Apr 25, 2020

Thanks for updating this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP2E MP2E MP2E approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AXDOOMER @MP2E @Janik-Haag