Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosh: fix build with bash-completion 2.10 #85919

Merged
merged 1 commit into from Apr 24, 2020
Merged

mosh: fix build with bash-completion 2.10 #85919

merged 1 commit into from Apr 24, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Apr 24, 2020 •
edited

Motivation for this change

Fixes #85893

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peti (because it involves bash-completion, I want to make sure my patch is reasonable)

@ofborg ofborg bot requested a review from viric April 24, 2020 07:24
@flokli flokli marked this pull request as draft April 24, 2020 09:46
@KamilaBorowska KamilaBorowska marked this pull request as ready for review April 24, 2020 10:47
@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Apr 24, 2020 •
edited

I don't understand autoconf, so I decided to make NixOS-only patch, it's non-ideal, but eh...

@Mic92 Mic92 merged commit 58c693c into NixOS:master Apr 24, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 24, 2020

I assume the next release of mosh will have an upstream fix anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@viric viric Awaiting requested review from viric

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mosh fails to build when installing bash completions
3 participants
@KamilaBorowska @Mic92 @flokli