Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tartube: init at 2.0.016 #85948

Merged
merged 1 commit into from Apr 25, 2020
Merged

tartube: init at 2.0.016 #85948

merged 1 commit into from Apr 25, 2020

Conversation

mkg20001
Copy link
Member

Motivation for this change

Fix #84655
This work uses @pbogdan's expression from #84655 (comment)

@pbogdan: I didn't find any issues with the app, it seems to work. I also have made you the author of the commit, since I believe you should get the honor of being the commit author. Just comment if you don't like that.

I've added myself and @luc65r as a maintainer - I've asked him about that and he aggreed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member

pbogdan commented Apr 24, 2020

Sounds good to me, thank you! And just a heads up - looks like gdk_pixbuf needs to be swapped for gdk-pixbuf to make the CI check happy as it doesn't accept aliases.

@mkg20001 mkg20001 force-pushed the pkg/tartube branch 2 times, most recently from 6a4b830 to 81f93d7 Compare April 25, 2020 08:06
worldofpeace
worldofpeace approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works.

@worldofpeace
Copy link
Contributor

Also verified we have all typelibs by looking at gi.repository imports.

@worldofpeace worldofpeace merged commit bef95ff into NixOS:master Apr 25, 2020
@worldofpeace
Copy link
Contributor

Thanks ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tartube
3 participants
@mkg20001 @pbogdan @worldofpeace