Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neomutt: 20200417 -> 20200424 #85959

Merged
merged 1 commit into from Apr 27, 2020
Merged

neomutt: 20200417 -> 20200424 #85959

merged 1 commit into from Apr 27, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 24, 2020

Motivation for this change

https://github.com/neomutt/neomutt/releases/tag/20200424

Please note that I'd wait with updating the package until neomutt/neomutt#2295 is fixed since using neomutt to read a local maildir (synced with another tool from an IMAP server) is a rather common use-case IMHO.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested review from flokli and jfrankenau April 24, 2020 20:17
@ofborg ofborg bot requested review from erikryb, cstrahan and vrthra April 24, 2020 20:25
@flokli
Copy link
Contributor

flokli commented Apr 24, 2020

@Ma27 with neomutt/neomutt#2295 being closed, WDYT about this?

@Ma27
Copy link
Member Author

Ma27 commented Apr 24, 2020

As there's a simple workaround, I'd be fine with merging, however we shouldn't backport this since this release seems to "break" existing configurations.

@Ma27 Ma27 marked this pull request as ready for review April 24, 2020 20:41
@flokli
Copy link
Contributor

flokli commented Apr 24, 2020

I need to admit, I only use virtual folders. Let's ask @andir ;-)

@Ma27 Ma27 requested a review from andir April 24, 2020 22:44
@andir
Copy link
Member

andir commented Apr 26, 2020 via email

@flokli
Copy link
Contributor

flokli commented Apr 26, 2020

It's in the PR description and previous comments.

@flokli
Copy link
Contributor

flokli commented Apr 27, 2020

Alright, let's merge this, but not backport.

@flokli flokli merged commit 98dbff9 into NixOS:master Apr 27, 2020
@Ma27 Ma27 deleted the bump-neomutt branch April 27, 2020 12:48
@Ma27
Copy link
Member Author

Ma27 commented May 3, 2020

The issue has been fixed in the end btw: neomutt/neomutt@f073a70

@flokli
Copy link
Contributor

flokli commented May 4, 2020

@Ma27 given the fix is now part neomutt-20200501, do you want to bump 20.03 to it, or should we keep it?

@Ma27
Copy link
Member Author

Ma27 commented May 4, 2020

I don't see a reason not to, the last two releases mostly contained bugfixes.

@Ma27
Copy link
Member Author

Ma27 commented May 5, 2020

Ported to stable as 78332ac

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

@erikryb erikryb Awaiting requested review from erikryb

@cstrahan cstrahan Awaiting requested review from cstrahan

@vrthra vrthra Awaiting requested review from vrthra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @flokli @andir