Skip to content

dump: init at 0.4b46 #85934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

dump: init at 0.4b46 #85934

merged 1 commit into from
Sep 10, 2020
+26 −0

Conversation

falsifian
Copy link
Contributor

Tested by dumping a small filesystem and extracting files from the dump using
restore -i. It worked, but complained:

DUMP: WARNING: no file `/nix/store/y7r0q9l7663vii0j0lqlrwyi073z81n8-dump-0.4b46/etc/dumpdates'

Still, it is enough for my purposes; and I think it would be a useful addition to nixpkgs.

Motivation for this change

I'm trying out this classic dump/restore utility for simple backups.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@falsifian
dump: init at 0.4b46

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 8AB0E99F622EC03E
Verified
Learn about vigilant mode
df686d3 
Tested by dumping a small filesystem and extracting files from the dump using
restore -i. It worked, but complained:
  DUMP: WARNING: no file `/nix/store/y7r0q9l7663vii0j0lqlrwyi073z81n8-dump-0.4b46/etc/dumpdates'
@falsifian falsifian added the 8.has: package (new) This PR adds a new package label Apr 24, 2020
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 24, 2020
@Lassulus
Copy link
Member

there is a sbin folder in the output, I guess we don't need that?

@falsifian
Copy link
Contributor Author

I just looked into sbin. It looks like pkgs/build-support/setup-hooks/move-sbin.sh automatically moves the contents of sbin to bin and creates the symlink from sbin to bin, probably during the fixup phase.

Whoever wrote move-sbin.sh decided it should create the sbin symlink; not sure it makes sense to add complexity by overriding that behaviour on a case-by-case basis.

@Lassulus Lassulus merged commit 4324089 into NixOS:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@falsifian @Lassulus