Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcbor: Fix pkgconfig being placed correctly #85935

Merged
merged 1 commit into from Apr 27, 2020
Merged

libcbor: Fix pkgconfig being placed correctly #85935

merged 1 commit into from Apr 27, 2020

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Apr 24, 2020

Fixes #85932

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arianvp
Copy link
Member Author

arianvp commented Apr 24, 2020

@GrahamcOfBorg build libfido2 libcbor

@arianvp
Copy link
Member Author

arianvp commented Apr 24, 2020

cc @dtzWill

@ofborg ofborg bot requested a review from dtzWill April 24, 2020 12:25
@arianvp
Copy link
Member Author

arianvp commented Apr 24, 2020

This is causing a mass-rebuild because our openssh package depends on this. I'm rebasing to staging

@arianvp arianvp changed the base branch from master to staging April 24, 2020 13:10
@arianvp
Copy link
Member Author

arianvp commented Apr 24, 2020

@GrahamcOfBorg build libfido2 libcbor ssh

@veprbl veprbl added this to WIP in Staging via automation Apr 25, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Apr 25, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 27, 2020

Validated the pcfiles are broken on master and fixed here, thanks for the fix!

It'd be nice if we had some kind of auto-validation for pkg-config files. I also saw the aws-sdk-cpp pcfiles are broken, also due to cmake issues with upstream's build not being quite right.

@bhipple bhipple merged commit d9e9e50 into NixOS:staging Apr 27, 2020
Staging automation moved this from Needs review to Done Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libcbor doesn't install their pkgconfig files correctly
2 participants
@arianvp @bhipple