Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19.09 mutter backports #85969

Merged
merged 2 commits into from Apr 25, 2020
Merged

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Same motivation as #85966, but we just use patches in gnome3.mutter.
I do updates from gnome-3-28 branch anyways, so I did the same for gnome3.mutter328.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 24, 2020

@GrahamcOfBorg test pantheon gnome3 gnome3-xorg

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 24, 2020
@ofborg ofborg bot requested review from jtojnar and hedning April 24, 2020 22:23
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/85969
31 package built:
adapta-gtk-theme arc-theme chrome-gnome-shell gnome3.gnome-control-center gnome3.gnome-session gnome3.gnome-shell gnome3.gnome-terminal gnome3.gnome-tweaks gnome3.gpaste gnome3.mutter pantheon.mutter gnome3.pomodoro gnomeExtensions.gsconnect pantheon.elementary-greeter pantheon.elementary-gsettings-schemas pantheon.elementary-session-settings pantheon.gala pantheon.switchboard-plug-pantheon-shell pantheon.switchboard-with-plugs pantheon.wingpanel pantheon.wingpanel-applications-menu pantheon.wingpanel-indicator-bluetooth pantheon.wingpanel-indicator-datetime pantheon.wingpanel-indicator-keyboard pantheon.wingpanel-indicator-network pantheon.wingpanel-indicator-nightlight pantheon.wingpanel-indicator-notifications pantheon.wingpanel-indicator-power pantheon.wingpanel-indicator-session pantheon.wingpanel-indicator-sound pantheon.wingpanel-with-indicators

@jonringer
Copy link
Contributor

I don't see the cherry-pick -x messages though

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 24, 2020

@jonringer Right, I backported db49d6ffc885a05cc30ee349ed222e7bcb3844f9 from release-20.03. The other one is divergence.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 85969 1

31 package built: - adapta-gtk-theme - arc-theme - chrome-gnome-shell - gnome3.gnome-control-center (gnome3.gnome_control_center) - gnome3.gnome-session (gnome3.gnome_session) - gnome3.gnome-shell (gnome3.gnome_shell) - gnome3.gnome-terminal (gnome3.gnome_terminal) - gnome3.gnome-tweaks (gnome3.gnome-tweak-tool) - gnome3.gpaste - gnome3.mutter - pantheon.mutter (gnome3.mutter328) - gnome3.pomodoro - gnomeExtensions.gsconnect - pantheon.elementary-greeter - pantheon.elementary-gsettings-schemas - pantheon.elementary-session-settings - pantheon.gala - pantheon.switchboard-plug-pantheon-shell - pantheon.switchboard-with-plugs - pantheon.wingpanel - pantheon.wingpanel-applications-menu - pantheon.wingpanel-indicator-bluetooth - pantheon.wingpanel-indicator-datetime - pantheon.wingpanel-indicator-keyboard - pantheon.wingpanel-indicator-network - pantheon.wingpanel-indicator-nightlight - pantheon.wingpanel-indicator-notifications - pantheon.wingpanel-indicator-power - pantheon.wingpanel-indicator-session - pantheon.wingpanel-indicator-sound - pantheon.wingpanel-with-indicators

@jonringer jonringer merged commit c4799f0 into NixOS:release-19.09 Apr 25, 2020
@worldofpeace worldofpeace deleted the mutter-backports branch April 25, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants