Skip to content

gnome3.updateScript: Add freeze functionality #85968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Apr 24, 2020

Motivation for this change

On stable releases, we will want to change the freeze parameter in pkgs/desktops/gnome-3/update.nix to true to limit the gnome update script to only bump patch versions.

Things done
  • Tested on release-20.03 branch with freeze = true
  • Tested on master branch

cc @worldofpeace @hedning

Sorry, something went wrong.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 24, 2020
worldofpeace
worldofpeace previously approved these changes Apr 24, 2020
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, could you run find-latest-version.py through black?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 24, 2020
@jtojnar jtojnar force-pushed the gnome-update-freezer branch from 3f1b793 to 51c2e73 Compare April 24, 2020 22:28
@worldofpeace worldofpeace dismissed their stale review April 24, 2020 23:04

stale now

@jtojnar jtojnar force-pushed the gnome-update-freezer branch from 51c2e73 to 350dc80 Compare April 24, 2020 23:10
@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 24, 2020

Cool.

So now we get an error: list index 1 is out of bounds out of bounds error at lib.versions.minor

@jtojnar
Copy link
Member Author

jtojnar commented Apr 24, 2020

libgudev?

@worldofpeace
Copy link
Contributor

libgudev?

Yes, that attribute gives out of bounds because its version 233

@jtojnar jtojnar force-pushed the gnome-update-freezer branch from 350dc80 to 372393f Compare April 24, 2020 23:18
jtojnar added 2 commits April 25, 2020 01:19

Verified

This commit was signed with the committer’s verified signature.
jtojnar Jan Tojnar
On stable releases, we will want to change the freeze parameter in pkgs/desktops/gnome-3/update.nix
to true to limit the gnome update script to only bump patch versions.

Verified

This commit was signed with the committer’s verified signature.
jtojnar Jan Tojnar
@jtojnar jtojnar force-pushed the gnome-update-freezer branch from 372393f to b0a2fb1 Compare April 24, 2020 23:19
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran update.nix on gnome3 attribute on master without frozen without a problem ✔️
I ran update.nix on gnome3 attribute on release-20.03 without a problem,
and packages were updated in the proper bound ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants