Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] signal-desktop: 1.33.1 -> 1.33.3 (backport) #85937

Merged
merged 1 commit into from Apr 24, 2020
Merged

[20.03] signal-desktop: 1.33.1 -> 1.33.3 (backport) #85937

merged 1 commit into from Apr 24, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 24, 2020

(cherry picked from commit edc4211)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
signal-desktop: 1.33.1 -> 1.33.3
489d014 
(cherry picked from commit edc4211)
@primeos
Copy link
Member Author

primeos commented Apr 24, 2020

@GrahamcOfBorg test signal-desktop

@primeos primeos changed the title signal-desktop: 1.33.1 -> 1.33.3 [20.03] signal-desktop: 1.33.1 -> 1.33.3 (backport) Apr 24, 2020
@ofborg ofborg bot requested review from equirosa and ixmatus April 24, 2020 13:21
primeos referenced this pull request Apr 24, 2020
@primeos
signal-desktop: 1.33.1 -> 1.33.3
edc4211
@primeos primeos merged commit b18d66f into NixOS:release-20.03 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equirosa equirosa Awaiting requested review from equirosa

@ixmatus ixmatus Awaiting requested review from ixmatus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos