[WIP] AsyncFIFO: disable read from dual-port Memory when FIFO empty #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids CDC hazard described in issue amaranth-lang#217.
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 82.58% 82.58%
=======================================
Files 35 35
Lines 5962 5962
Branches 1213 1213
=======================================
Hits 4924 4924
Misses 872 872
Partials 166 166
Continue to review full report at Codecov.
|
awygle
changed the title
whitequark
force-pushed
the
master
branch
2 times, most recently
from
c86aaa2
to
d71e19e
Compare
|
I'm not comfortable doing this until #387 is implemented, so I'm just going to close this for now and put any time I'd have spent on this into that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids CDC hazard described in issue #217.