Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] gnome3.updateScript: Add freeze functionality #85973

Merged
merged 3 commits into from Apr 25, 2020
Merged

[20.03] gnome3.updateScript: Add freeze functionality #85973

merged 3 commits into from Apr 25, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Backports #85968

This will allow me to perform updates in the stable release with ease.

942a601 is not a backport because it will only be frozen on release branches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar and others added 3 commits April 24, 2020 19:37
@jtojnar @worldofpeace
gnome3.updateScript: Add freeze functionality
dd45b8a 
On stable releases, we will want to change the freeze parameter in pkgs/desktops/gnome-3/update.nix
to true to limit the gnome update script to only bump patch versions.

(cherry picked from commit 974f11c)
@jtojnar @worldofpeace
gnome3.updateScript: format with black
89a74d4 
(cherry picked from commit b0a2fb1)
@worldofpeace
gnome3.updateScript: frozen
942a601
@worldofpeace worldofpeace merged commit ace9deb into NixOS:release-20.03 Apr 25, 2020
@worldofpeace worldofpeace deleted the gnome-update-freezer-20.03 branch April 25, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar