Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slimrat: remove #85944

Merged
merged 1 commit into from Apr 25, 2020
Merged

slimrat: remove #85944

merged 1 commit into from Apr 25, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Apr 24, 2020 •
edited

The package was marked as broken for 3 years, there were no upstream updates for 8 years, we have an 11 years version, RapidShare doesn't exist for 5 years, MegaUpload doesn't exist for 8 years, and other supported uploaders likely changed so much that this program doesn't work on those. I think it's safe to say that this program is not going to work.

I'm not going to bother with adding slimrat to aliases.nix, because at this point nobody should have it in their .nix files unless someone wants that alias.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
slimrat: remove
409f575 
The package was marked as broken for 3 years, there were no
upstream updates for 8 years, and the program requires third
party services that don't provide APIs to work. I think it's
safe to say that this program is not going to work.
@worldofpeace worldofpeace merged commit d17a130 into NixOS:master Apr 25, 2020
@worldofpeace
Copy link
Contributor

I'm confident enough that no one should use it, I've backported it to 20.03 4e85c84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@emilazy emilazy emilazy approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @worldofpeace @jonringer @emilazy