Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atlassian-confluence: 7.4.0 -> 7.5.0 #89207

Merged
merged 1 commit into from Jun 3, 2020
Merged

atlassian-confluence: 7.4.0 -> 7.5.0 #89207

merged 1 commit into from Jun 3, 2020

Conversation

ciil
Copy link
Member

@ciil ciil commented May 30, 2020

Motivation for this change

Upgrade Confluence to 7.5.0
Adding myself to maintainers list

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ciil ciil requested a review from WilliButz May 30, 2020 09:57
@ofborg ofborg bot requested review from fpletz and globin May 30, 2020 10:04
WilliButz
WilliButz approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@WilliButz WilliButz merged commit d7f3370 into NixOS:master Jun 3, 2020
@WilliButz
Copy link
Member

backported together with 28d19fa in 5c5e386

@WilliButz WilliButz added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ciil @WilliButz