unit: Expose PHP expressions used so it can easily be accessed for configs #89224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Izorkin
approved these changes
May 30, 2020
|
Thanks. |
talyz
reviewed
May 31, 2020
There was a problem hiding this comment.
Looks good :) This should probably be documented, though, since it's not obvious unless you look at the test. If we want to make unit nice to use, we should probably work more on the config parameter, however, so maybe it's best to hold off on documenting until we know if this is how it's going to work in 20.09 or not.
| "index": "info.php" | ||
| "index": "info.php", | ||
| "options": { | ||
| "file": "${pkgs.unit.usedPhp74}/lib/php.ini" |
There was a problem hiding this comment.
You can reference the ini file with the phpIni attribute, which should be more future proof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since the used PHP derivation contains all the extensions and the configuration of the extensions it kinda makes sense which PHP is used to be able to access this.
Another way would be to symlink in this ini file into the
unitderivation for easy access. But I kinda like this way...Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)