Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7970: [Win32] Disable event loop on crash to prevent recursive faults #8176

Merged
merged 2 commits into from Jun 1, 2020
Merged

Fix #7970: [Win32] Disable event loop on crash to prevent recursive faults #8176

merged 2 commits into from Jun 1, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 29, 2020 •
edited by LordAro

Closes #8175

LordAro
LordAro reviewed May 29, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for its correctness, but it definitely looks better...

@nielsmh
Copy link
Contributor

nielsmh commented May 29, 2020

This should not affect the ability of the screenshot to generate, right?

@glx22
Copy link
Contributor Author

glx22 commented May 29, 2020

Hmm I should try that. I just tested with the broken save from #7970.

@glx22
Copy link
Contributor Author

glx22 commented May 29, 2020

Ok I checked, screenshot is generated. And there's an issue in the crash dialog (not related to this change), _crash_desc doesn't fit.

@glx22 glx22 merged commit b3ddf2c into OpenTTD:master Jun 1, 2020
@glx22 glx22 deleted the wndproc branch June 1, 2020 12:10
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Jun 1, 2020
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro left review comments

@Yexo Yexo Yexo approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glx22 @nielsmh @Yexo @LordAro