Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

act: 0.2.8 -> 0.2.9 #89228

Merged
merged 1 commit into from May 31, 2020
Merged

act: 0.2.8 -> 0.2.9 #89228

merged 1 commit into from May 31, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 30, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.


buildFlagsArray = [ "-ldflags=-s -w -X main.version=${version}" ];

meta = with lib; {
description = "Run your GitHub Actions locally";
homepage = "https://github.com/nektos/act";
changelog = "https://github.com/nektos/act/releases/tag/v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marsam Interesting. I saw meta.changelog mentioned in the manuals, but seldom saw it being used. Is there any policy/convention for adding this to projects (for examples, ones that have nice changelogs in their release descriptions), or is this just a matter of personal preference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK there is no policy, I usually add it to packages which I'm interested in their changelog.
btw, congrats for becoming a committer, we're delighted to have you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As some extra context, the r-ryantm bot will now link to meta.changelog if it exists, like so:
#89682

So please do add these, as it saves reviewer time and is a nice quality-of-life improvement!

Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
nixpkgs-review passes
executable reports version

@marsam marsam merged commit e94d97d into NixOS:master May 31, 2020
@marsam marsam deleted the update-act branch May 31, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants