Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cde-gtk-theme: init at 1.3 #89163

Merged
merged 1 commit into from Jun 1, 2020
Merged

cde-gtk-theme: init at 1.3 #89163

merged 1 commit into from Jun 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2020

Motivation for this change

Gtk2 / Gtk3 theme mimicking CDE / Motif

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from sauyon May 29, 2020 11:54
@sauyon
Copy link
Member

sauyon commented May 29, 2020

I'm getting a 410 gone from the URL:

trying https://dllb2.pling.com/api/files/download/j/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpZCI6IjE1MjU3Mzc1MTAiLCJ1IjpudWxsLCJsdCI6ImRvd25sb2FkIiwicyI6ImI2NTBiZjk0NDEzYjRjYmRmNzgxMWZhNmIyZjAzMzYwNmUzNDIxNzYxYmY0MDMzYTgxYjk0ZDUwZTdkMDlkOWIxYTQ5MzYzODk4NTA0YThmODQxYWMxYTZlMzMwZDY1MmRhMzI3ZDc1ZDRkYTIzMzAwZWI5ZWU3MGJiOTBjNGI2IiwidCI6MTU5MDc1MjU2MSwic3RmcCI6ImJjYTRlNTQ4NDlhMmJkM2I2MGY5MGY0NmU4OTc1MjEzIiwic3RpcCI6IjE3Ni4xOTMuMTQuMTA2In0.1-A_r3bCm-5pJQKviPcWKfrsdm8Xp6AyHiU0d7LJj3w/cdetheme1.3.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 410 Gone
error: cannot download cdetheme1.3.tar.gz from any mirror

Seems like this is a temporary URL?

@ghost ghost marked this pull request as draft May 30, 2020 09:30
@ghost ghost marked this pull request as ready for review May 30, 2020 19:18
@ghost
Copy link
Author

ghost commented May 30, 2020

@sauyon Fixed, thanks

@sauyon
Copy link
Member

sauyon commented May 31, 2020

The details section of the theme description seem to suggest that it's licensed under GPLv3, but that's not found in the repo you added as a source. Are you the author of the theme? It looks like you own the opencode repo, at least.

Otherwise, this LGTM.

I'll test this on Arch in a bit.

@ghost ghost changed the title cdetheme: init at 1.3 cde-gtk-theme: init at 1.3 May 31, 2020
@ghost
Copy link
Author

ghost commented May 31, 2020 •
edited by ghost

@sauyon No, I'm not the author, just uploaded it to opencode. I've contacted the author with kind ask to upload it by himself and add license.

@ghost
Copy link
Author

ghost commented Jun 1, 2020 •
edited by ghost

@sauyon Theme author uploaded it to github and added license 👍 I've updated the package accordingly.

@ghost ghost requested a review from sauyon June 1, 2020 06:23
romildo
romildo requested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fits better at the ### DATA section instead of the current ### BUILD SUPPORT section of all-packages.nix.

@ghost ghost requested a review from romildo June 1, 2020 11:25
@ghost
Copy link
Author

ghost commented Jun 1, 2020

@romildo Fixed, thank you!

sauyon
sauyon approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickHu
Copy link
Contributor

NickHu commented Jun 1, 2020

Tested in lxappearance on nixos.

Thanks for your contribution!

Result of nixpkgs-review pr 89163 1

1 package built:
- cde-gtk-theme

@NickHu NickHu merged commit 052fa90 into NixOS:master Jun 1, 2020
@ghost
Copy link
Author

ghost commented Jun 1, 2020

@romildo @NickHu @sauyon Thanks!

@ghost ghost deleted the cdetheme branch June 1, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sauyon @NickHu @romildo