Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cue: 0.1.2 -> 0.2.0 #89185

Merged
merged 1 commit into from May 30, 2020
Merged

cue: 0.1.2 -> 0.2.0 #89185

merged 1 commit into from May 30, 2020

Conversation

rudolph9
Copy link
Contributor

Motivation for this change

New version released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
NixOS/nixpkgs [cue-0.2.0] » nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.03 MiB download, 0.13 MiB unpacked):
  /nix/store/vrlz9jf4z0j7ssmnhzhxw8lhlca3cdmv-nixpkgs-review-2.3.1
copying path '/nix/store/vrlz9jf4z0j7ssmnhzhxw8lhlca3cdmv-nixpkgs-review-2.3.1' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Total 12 (delta 8), reused 8 (delta 8), pack-reused 4
Unpacking objects: 100% (12/12), 1.96 KiB | 1002.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master     -> refs/nixpkgs-review/0
$ git worktree add /home/krudolph/.cache/nixpkgs-review/rev-fb8c034bb60aecf35f5ab5f1430f68aeb284e83a-dirty/nixpkgs 401df90cfa428f4c008686488dcda13a17aac7eb
Preparing worktree (detached HEAD 401df90cfa4)
Updating files: 100% (21808/21808), done.
HEAD is now at 401df90cfa4 Merge pull request #89153 from alapshin/android-studio
$ nix-env -f /home/krudolph/.cache/nixpkgs-review/rev-fb8c034bb60aecf35f5ab5f1430f68aeb284e83a-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants