Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-daemon module: do not rely on the daemon being running #89191

Merged
merged 1 commit into from May 30, 2020
Merged

nix-daemon module: do not rely on the daemon being running #89191

merged 1 commit into from May 30, 2020

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented May 29, 2020

Motivation for this change

Fix #72372 on 20.03, backporting the relevant changes from #87182 without the backwards-compatibility-breaking parts of it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog Ekleog mentioned this pull request May 29, 2020
Closed
@Ekleog
Copy link
Member Author

Ekleog commented May 29, 2020

@ofborg build nixosTests.installer

Let's check that nixos-rebuild still works

symphorien
symphorien approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that a switch to this revision of nixpkgs which is also restarting nix-daemon works. So this really fixes #72372.

@Ekleog Ekleog merged commit acba0f1 into NixOS:release-20.03 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ekleog @symphorien