ashuffle: init at version 3.4.0 #89186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
suggested changes
May 29, 2020
alexarice
approved these changes
May 30, 2020
There was a problem hiding this comment.
Builds with nix-review and at least runs help page. I would still check if there is some way to move cmake to a native build input but otherwise looks good
@GrahamcOfBorg build
|
Anything I can do to help get this moved along? |
|
I'd try posting on the "PR already reviewed" discourse post. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Please rebase the first two commits to master. |
|
Should be good now? |
alexarice
suggested changes
Aug 22, 2020
danieldk
reviewed
Aug 22, 2020
alexarice
approved these changes
Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ashuffleautomatically shuffles the contents of anmpdmusic library when the playlist runs out of tracks. It has a grouping feature which can be used to shuffle tracks based on their tags (in other words, you can shuffle artists or albums).I use it to keep my
mpdplaylist supplied with music, even when I am not controlling it directly.I also added myself to the maintainers list for this package.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)