Remove ability to specify sub-product with ':' #23883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used in sauce, where you could set the product to something like sauce:firefox:63. There were multiple problems with it: - it wasn't documented, - it overlaps with the --sauce-browser and --sauce-version flags, and - it actually would crash wpt if you didn't set a sub-product, even thought it was meant to be optional! The first user of sauce in a long time ran into this problem immediately, so let's just remove it and make people use --sauce-browser and --sauce-version. Fixes #23875
jgraham
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only used in sauce, where you could set the product to
something like sauce:firefox:63. There were multiple problems with it:
thought it was meant to be optional!
The first user of sauce in a long time ran into this problem
immediately, so let's just remove it and make people use --sauce-browser
and --sauce-version.
Fixes #23875