Fix calculation of before change style for CSS transitions #23860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 29, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2220263
branch
4 times, most recently
from
07f8387
to
2baf0de
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2220263
branch
4 times, most recently
from
c891dc7
to
a9d936e
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2220263
branch
7 times, most recently
from
d1e16e3
to
04939f3
Compare
This patch performs a lazy calculation of the before change style once it has been determined that a transition is being retargeted. In doing so, the current position is correctly updated to reflect changes made via the web-animation API. The path also addresses a bug in the calculation of current time, in the case of a paused or play-pending animation. Bug: 1082401, 888661, 547609 Change-Id: I4b76879d840b482da8ebf23c1aad41b881fafce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220263 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#783675}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2220263
branch
from
04939f3
to
f3772b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch performs a lazy calculation of the before change style once
it has been determined that a transition is being retargeted. In doing
so, the current position is correctly updated to reflect changes made
via the web-animation API. The path also addresses a bug in the
calculation of current time, in the case of a paused or play-pending
animation.
Bug: 1082401, 888661, 547609
Change-Id: I4b76879d840b482da8ebf23c1aad41b881fafce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220263
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#783675}