Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripgrep: 12.1.0 -> 12.1.1 #89172

Merged
merged 1 commit into from May 29, 2020
Merged

ripgrep: 12.1.0 -> 12.1.1 #89172

merged 1 commit into from May 29, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 29, 2020

https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md#1211-2020-05-29

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, Ma27 and tailhook May 29, 2020 14:00
@Ma27 Ma27 merged commit 1b4497c into NixOS:master May 29, 2020
@zowoq zowoq deleted the ripgrep branch May 29, 2020 21:22
@mweinelt
Copy link
Member

mweinelt commented Jun 7, 2020

Tests are failing on aarch64

failures:

---- misc::compressed_brotli stdout ----
thread 'misc::compressed_brotli' panicked at '

==========
command failed but expected success!

command: "/build/source/target/debug/deps/../rg" "--path-separator" "/" "-z" "Sherlock" "sherlock.br"

cwd: /build/ripgrep-tests/compressed_brotli/103

dir list: ["/build/ripgrep-tests/compressed_brotli/103", "/build/ripgrep-tests/compressed_brotli/103/sherlock.br"]

status: exit code: 2

stdout:

stderr: sherlock.br: <stderr is empty>


==========
', tests/util.rs:406:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- misc::compressed_lz4 stdout ----
thread 'misc::compressed_lz4' panicked at '

==========
command failed but expected success!

command: "/build/source/target/debug/deps/../rg" "--path-separator" "/" "-z" "Sherlock" "sherlock.lz4"

cwd: /build/ripgrep-tests/compressed_lz4/107

dir list: ["/build/ripgrep-tests/compressed_lz4/107", "/build/ripgrep-tests/compressed_lz4/107/sherlock.lz4"]

status: exit code: 2

stdout:

stderr: sherlock.lz4: <stderr is empty>


==========
', tests/util.rs:406:13

---- misc::compressed_zstd stdout ----
thread 'misc::compressed_zstd' panicked at '

==========
command failed but expected success!

command: "/build/source/target/debug/deps/../rg" "--path-separator" "/" "-z" "Sherlock" "sherlock.zst"

cwd: /build/ripgrep-tests/compressed_zstd/111

dir list: ["/build/ripgrep-tests/compressed_zstd/111", "/build/ripgrep-tests/compressed_zstd/111/sherlock.zst"]

status: exit code: 2

stdout:

stderr: sherlock.zst: <stderr is empty>


==========
', tests/util.rs:406:13


failures:
    misc::compressed_brotli
    misc::compressed_lz4
    misc::compressed_zstd

test result: FAILED. 252 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out

@zowoq
Copy link
Contributor Author

zowoq commented Jun 7, 2020

Tests are failing on aarch64

More context might be helpful?

@mweinelt
Copy link
Member

mweinelt commented Jun 7, 2020

It only happens when crosscompiling to aarch64 from x86_64 using binfmt/qemu-aarch64. Does not happen on native builds on aarch64. I don't have more information for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants