Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onedrive: 2.3.13 ->! 2.4.2 #89198

Closed
wants to merge 1 commit into from
Closed

onedrive: 2.3.13 ->! 2.4.2 #89198

wants to merge 1 commit into from
+8 −3

Conversation

SRGOM
Copy link
Member

@SRGOM SRGOM commented May 30, 2020

Motivation for this change

Version bump

Supersededs: #83280 and #86707

New PR because I use shallow nixpkgs and github does't allow me to push on the old branch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fadenb

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 30, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/166

@SRGOM SRGOM mentioned this pull request Jun 4, 2020
Closed
@SRGOM
Copy link
Member Author

SRGOM commented Jun 5, 2020

Updated to 2.4.2, also started a new convention, as suggested by @danbst here- #83280 (comment) where if user intervention is required then the -> is followed by a bang.

Please review and approve.

@SRGOM SRGOM mentioned this pull request Jun 5, 2020
Closed
@fadenb
Copy link
Contributor

fadenb commented Jun 19, 2020

Is there anything else that needs to be done before this can be merged?

@Lassulus
Copy link
Member

why is there an exclamation mark in the message?

@infinisil
Copy link
Member

@Lassulus #89198 (comment)

infinisil
infinisil reviewed Aug 24, 2020
View reviewed changes
pkgs/applications/networking/sync/onedrive/default.nix
@@ -21,7 +21,7 @@ stdenv.mkDerivation rec {
description = "A complete tool to interact with OneDrive on Linux";
homepage = "https://github.com/abraunegg/onedrive";
license = licenses.gpl3;
maintainers = with maintainers; [ srgom ianmjones ];
maintainers = with maintainers; [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the maintainers?

@SuperSandro2000
Copy link
Member

Version on master is already never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

@fadenb fadenb

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SRGOM @nixos-discourse @fadenb @Lassulus @infinisil @SuperSandro2000