Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networking: check interface state files exist before acting on them #89159

Merged
merged 1 commit into from Jun 12, 2020
Merged

nixos/networking: check interface state files exist before acting on them #89159

merged 1 commit into from Jun 12, 2020

Conversation

datafoo
Copy link
Contributor

@datafoo datafoo commented May 29, 2020

Fix #89158

Motivation for this change
Things done
  • Tested using NixOps
  • Built on platform(s)
    • NixOS
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from lheckemann and rnhmjoj May 31, 2020 14:11
@lheckemann
Copy link
Member

@ofborg test networking.scripted

lheckemann
lheckemann approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, not tested myself but I trust the networking tests :)

rnhmjoj
rnhmjoj approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this should happen when static routes are configured but no static addresses are given or vice versa. Can you confirm?

In any case this looks good. Thank you.

@datafoo
Copy link
Contributor Author

datafoo commented Jun 2, 2020

IIUC this should happen when static routes are configured but no static addresses are given or vice versa. Can you confirm?

I can only confirm the case I have mentioned in the issue #89158: I have configured a bond0 bond with ens33 and ens34 interfaces. I configured static IPs for networking.interfaces.bond0 and I don't configure anything for networking.interfaces.ens33 or networking.interfaces.ens34.

@datafoo
Copy link
Contributor Author

datafoo commented Jun 12, 2020

ping

@rnhmjoj rnhmjoj merged commit a2fd1ba into NixOS:master Jun 12, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 12, 2020

I have configured a bond0 bond with ens33 and ens34 interfaces. I configured static IPs for networking.interfaces.bond0 and I don't configure anything for networking.interfaces.ens33 or networking.interfaces.ens34.

Yes, it makes sense. Thank you, again.

@datafoo datafoo deleted the fix-issue-89158 branch January 10, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/network: error message from Address configuration pre-stop script when state file missing
3 participants
@datafoo @lheckemann @rnhmjoj