Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gem: init at 2020-03-26 #89192

Merged
merged 1 commit into from Aug 1, 2020
Merged

gem: init at 2020-03-26 #89192

merged 1 commit into from Aug 1, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented May 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes May 31, 2020
View reviewed changes
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
@raboof raboof force-pushed the init-puredata-gem-plugin-at-2020-03-26 branch from af57aa6 to 5b618da Compare May 31, 2020 18:35
@raboof raboof requested a review from doronbehar May 31, 2020 18:35
@raboof
Copy link
Member Author

raboof commented May 31, 2020

@doronbehar thanks for the review - updated!

doronbehar
doronbehar requested changes May 31, 2020
View reviewed changes
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor

Oh and you can mark all previous conversations as "resolved"

@raboof
Copy link
Member Author

raboof commented May 31, 2020

Oh and you can mark all previous conversations as "resolved"

Sure, I didn't know if the etiquette would be to mark them 'resolved' myself or leave that up to the reviewer :)

@doronbehar
Copy link
Contributor

Sure, I didn't know if the etiquette would be to mark them 'resolved' myself or leave that up to the reviewer :)

The weirdest thing is that I can't mark them as resolved :)...

@raboof raboof force-pushed the init-puredata-gem-plugin-at-2020-03-26 branch from 5b618da to 2fee801 Compare May 31, 2020 18:53
@raboof raboof requested a review from doronbehar May 31, 2020 18:53
@raboof raboof force-pushed the init-puredata-gem-plugin-at-2020-03-26 branch from 2fee801 to c5dfa14 Compare May 31, 2020 19:25
doronbehar
doronbehar approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and diff is perfect ⭐.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/195

mmilata
mmilata reviewed Jun 21, 2020
View reviewed changes
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated
# The patch below applies to the latest release (v0.94), but then the build
# fails. I didn't track down what changed between that version and the
# current master that fixes the build on Nix
version = "unstable-2020-03-26";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version must start with a digit, the "unstable" should go into pname.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, fixed

@raboof raboof force-pushed the init-puredata-gem-plugin-at-2020-03-26 branch from c5dfa14 to 7a81f6c Compare June 21, 2020 16:04
@raboof raboof requested a review from mmilata June 21, 2020 16:06
@raboof raboof force-pushed the init-puredata-gem-plugin-at-2020-03-26 branch from 7a81f6c to 476ffd1 Compare July 8, 2020 06:53
@raboof
Copy link
Member Author

raboof commented Jul 8, 2020

/marvin opt-in
/state needs_merger

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 8, 2020
@raboof
Copy link
Member Author

raboof commented Jul 8, 2020

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 8, 2020

The PR author cannot set the status to needs_merger.
Please wait for an external review.
If you are not the PR author and you are reading this, please review the usage of this bot.
You may be able to help.
Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@raboof
Copy link
Member Author

raboof commented Jul 20, 2020

perhaps @magnetophon or @cillianderoiste would like to do a review to push this over the finish line?

@magnetophon
Copy link
Member

@raboof It builds, but IDK how to test it.

@raboof
Copy link
Member Author

raboof commented Jul 21, 2020

For who wants to test, with the following shell.nix:

{ pkgs ? import <nixpkgs> {} }:

pkgs.mkShell {
  buildInputs = [
    (pkgs.puredata-with-plugins [ pkgs.gem ])
  ];
}

you can run pd -lib Gem and then open the examples in /nix/store/63j4zw6y7z58ajm84bxcxw7s75nid18b-gem-unstable-2020-03-26/lib/pd/extra/Gem/ . Most of them have a 'create' message you can click to create the GEM window.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/194

danieldk
danieldk reviewed Jul 31, 2020
View reviewed changes
pkgs/applications/audio/pd-plugins/gem/default.nix Outdated
autoreconfHook
pkg-config
file
libtool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether libtool is necessary? It should be propagated by autoreconfHook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - that must've been a leftover from before I found out about autoreconfHook (and was still pulling in autoconf separately.

Amended (and double-checked that pkg-config is still actually needed)

@raboof raboof force-pushed the init-puredata-gem-plugin-at-2020-03-26 branch from 476ffd1 to 8ea4f5d Compare August 1, 2020 07:43
@raboof raboof requested a review from danieldk August 1, 2020 07:44
@danieldk danieldk merged commit 7861d43 into NixOS:master Aug 1, 2020
@raboof
Copy link
Member Author

raboof commented Aug 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@mmilata mmilata mmilata approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@raboof @doronbehar @nixos-discourse @magnetophon @danieldk @mmilata