Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulp: fix build #89210

Merged
merged 3 commits into from May 30, 2020
Merged

pulp: fix build #89210

merged 3 commits into from May 30, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 30, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request May 30, 2020
Closed
11 tasks
@calbrecht calbrecht self-requested a review May 30, 2020 11:48
@calbrecht
Copy link
Member

Tested it locally, they build now. I guess pulp needs the pkgs.purescript within propagatedNativeBuildInputs, because without:

[nix-shell:~/ws/nixpkgs]$ pulp test
* ERROR: `purs` executable not found.

@Mic92
Copy link
Member Author

Mic92 commented May 30, 2020 •
edited

Tested it locally, they build now. I guess pulp needs the pkgs.purescript within propagatedNativeBuildInputs, because without:

[nix-shell:~/ws/nixpkgs]$ pulp test
* ERROR: `purs` executable not found.

I am not sure we should do this. We also do not bundle make with a C compiler. What is the common expectation here? An alternative would be to suffix $PATH to include purescript.

@Mic92 Mic92 changed the title Pulp pulp: fix build May 30, 2020
@Mic92 Mic92 merged commit 639d53b into NixOS:master May 30, 2020
@Mic92 Mic92 deleted the pulp branch May 30, 2020 18:56
@calbrecht
Copy link
Member

I am not sure we should do this. We also do not bundle make with a C compiler. What is the common expectation here? An alternative would be to suffix $PATH to include purescript.

That is a good point. I did not look at it this way :) Also it is very easy to overcome. I just haven't thought much about it.

@Mic92
Copy link
Member Author

Mic92 commented May 30, 2020

It is the upstream expectation though to bundle it. Hence they made purescript installed with pulp. That's why I added it in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@calbrecht calbrecht calbrecht approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @calbrecht @prusnak