Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musescore: Add missing inputs qtgraphicaleffects, qtquickcontrols2 #89204

Merged
merged 1 commit into from Jun 23, 2020
Merged

musescore: Add missing inputs qtgraphicaleffects, qtquickcontrols2 #89204

merged 1 commit into from Jun 23, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented May 30, 2020

Motivation for this change

Although MuseScore builds and starts without these, it’s unusable because the left palette fails to render, with these errors:

qrc:/qml/palettes/PalettesWidget.qml:21:1: module "QtQuick.Controls" version 2.1 is not installed

or

qrc:/qml/palettes/PalettesWidget.qml:47:5: Type PalettesWidgetHeader unavailable
qrc:/qml/palettes/PalettesWidgetHeader.qml:37:5: Type StyledButton unavailable
qrc:/qml/palettes/StyledButton.qml:22:1: module "QtGraphicalEffects" is not installed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
musescore: Add missing inputs qtgraphicaleffects, qtquickcontrols2
7ed1ae0 
Although MuseScore builds and starts without these, it’s unusable
because the left palette fails to render, with these errors:

qrc:/qml/palettes/PalettesWidget.qml:21:1: module "QtQuick.Controls" version 2.1 is not installed

or

qrc:/qml/palettes/PalettesWidget.qml:47:5: Type PalettesWidgetHeader unavailable
qrc:/qml/palettes/PalettesWidgetHeader.qml:37:5: Type StyledButton unavailable
qrc:/qml/palettes/StyledButton.qml:22:1: module "QtGraphicalEffects" is not installed

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@ofborg ofborg bot requested a review from vandenoever May 30, 2020 08:02
@vandenoever
Copy link
Contributor

Looks good.

doronbehar
doronbehar approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the changes fix the errors at hand. Thank you! 🎷 .

@grahamc grahamc merged commit 00aebe9 into NixOS:master Jun 23, 2020
@andersk andersk deleted the musescore branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@vandenoever vandenoever Awaiting requested review from vandenoever

Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andersk @vandenoever @doronbehar @grahamc