LIBCLANG_PATH hook [updated] #85489
Closed
LIBCLANG_PATH hook [updated] #85489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust’s clang-sys has a few ways to handle this: > libclang shared libraries will be searched for in the following directories: > the directory provided by the LIBCLANG_PATH environment variable > the bin and lib directories in the directory provided by llvm-config --libdir > the directories provided by LD_LIBRARY_PATH environment variable > a list of likely directories for the target platform (e.g., /usr/local/lib on Linux) > macOS only: the toolchain directory in the directory provided by xcode-select --print-path The other methods don’t work. LLVM still does not support pkg-config, llvm-config won’t have the libclang because we build clang and llvm separately, and LD_LIBRARY_PATH shouldn’t be messed with. More discussion here: https://discourse.nixos.org/t/how-to-correctly-populate-a-clang-and-llvm-development-environment-using-nix-shell/3864/2
This is set by clang’s setup-hook.
dreverri
reviewed
Sep 4, 2020
| @@ -40,6 +40,7 @@ in rustPlatform.buildRustPackage rec { | |||
| ''; | |||
|
|
|||
| nativeBuildInputs = [ pkgconfig clang ]; | |||
| bulidInputs = [ libclang ]; | |||
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
What's the status? Was it just forgotten? |
stale
bot
removed
the
2.status: stale
|
@JJJollyjim could you resolve merge conflicts? The fix is very much needed, still. |
stale
bot
added
the
2.status: stale
|
This was added (via an opt-in setup hook) in #159899, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is #67725 rebased against current staging, posting it as a separate pull request to trigger an ofborg eval.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)