Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: 1.44.0 -> 1.44.1 #85430

Merged
merged 2 commits into from Apr 18, 2020
Merged

vscode, vscodium: 1.44.0 -> 1.44.1 #85430

merged 2 commits into from Apr 18, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Apr 17, 2020 •
edited

(cherry picked from commit 4a129e6)

Original PR to master is here, #85249

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Roman Kuznetsov added 2 commits April 17, 2020 09:55
vscode: 1.44.0 -> 1.44.1
a5f5386 
(cherry picked from commit 4a129e6)
vscodium: 1.44.0 -> 1.44.1
41ed7bf 
(cherry picked from commit 4fd1f49)
@kuznero
Copy link
Member Author

kuznero commented Apr 17, 2020

Ping @worldofpeace

@ofborg ofborg bot requested review from eadwu and Synthetica9 April 17, 2020 08:07
@bhipple
Copy link
Contributor

bhipple commented Apr 18, 2020

Result of nixpkgs-review pr 85430 1

3 packages built:
- vscode
- vscode-with-extensions
- vscodium

@bhipple bhipple merged commit a604730 into NixOS:release-20.03 Apr 18, 2020
@kuznero kuznero deleted the release-20.03 branch April 20, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@bhipple bhipple bhipple approved these changes

@eadwu eadwu Awaiting requested review from eadwu

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuznero @bhipple @bachp