Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Python 3: Add support for running tests with Python 3 on TaskCl… #23062

Closed
wants to merge 1 commit into from

Conversation

ziransun
Copy link
Member

…uster CI

@stephenmcgruer
Copy link
Contributor

Just noting that this is marked 'WIP' and I believe Ziran is intended to iterate using TaskCluster checks on the PR.

@ziransun feel free to ask explicitly once you want outside eyes on this PR (whether that's a full review or just a question! :))

@ziransun
Copy link
Member Author

@jgraham @stephenmcgruer : Any chance to review this and see if it's reasonable?

@jgraham
Copy link
Contributor

jgraham commented Apr 17, 2020

I wonder if running all the tests under py3 daily is the right tradeoff. If we want to get a full result as a baseline we can get it from a trigger branch push. For ongoing work it seems like it could be more useful to get the infrastructure tests running under py3, since those could flag regression in PRs touching tools/.

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Apr 17, 2020

@jgraham - to me, the two reasons to do this (which I documented in #22784 where I asked Ziran to do this work) are:

  1. far more easily compare Python 3 to Python 2 (i.e. using wpt.fyi and cross-comparing two runs at the same SHA), and
  2. easily spot regressions (i.e. using wpt.fyi and cross-comparing consecutive runs of Python 3 at different SHAs)

It is also an exercise in continuing to move forward in our Python 3 support. Outside of wptserve (which is of course a sizable problem still to be surmounted), we're running out of test directories that don't work under Python 3. We have to answer the question of 'ok, what next on the way to Python 3', and I thought this was a useful exercise.

it seems like it could be more useful to get the infrastructure tests running under py3, since those could flag regression in PRs touching tools/.

That's a good idea and I think we should do that too, but I see it as complementary to having regular test suite runs.

Edit: Note that daily is not required, weekly would also be fine if there's capacity concerns.

@stephenmcgruer
Copy link
Contributor

is the right tradeoff

Sorry, I missed this statement the first time I read through. Can you explain further what you mean by 'tradeoff' here? (Is it a capacity concern, or something else?)

@stephenmcgruer
Copy link
Contributor

Closing this PR; we have switched the CI to Py3 and I think this particular experiment is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants