Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micro: 1.4.1 -> 2.0.3 #85501

Merged
merged 1 commit into from Apr 18, 2020
Merged

micro: 1.4.1 -> 2.0.3 #85501

merged 1 commit into from Apr 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2020 •
edited by ghost

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Apr 18, 2020

CC @dtzWill

@ofborg ofborg bot requested a review from dtzWill April 18, 2020 17:34
@Mic92
Copy link
Member

Mic92 commented Apr 18, 2020

@GrahamcOfBorg build micro

@ghost
Copy link
Author

ghost commented Apr 18, 2020

micro has some Go dependencies starting from 2.0.0. It seems to be using Go modules, so I can use either buildGoModule or buildGoPackage. Is one of them preferred?

@Mic92
Copy link
Member

Mic92 commented Apr 18, 2020

There are different opinions on this. Some people prefer buildGoModule for beeing simpler to update. Other prefer buildGoPackage because sources are deduplicate across different packages in nix in the binary cache.

@Mic92 Mic92 merged commit cd3bc38 into NixOS:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92