Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweethome3d: 6.2 -> 6.3 #85500

Merged
merged 1 commit into from May 4, 2020
Merged

sweethome3d: 6.2 -> 6.3 #85500

merged 1 commit into from May 4, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 18, 2020

Motivation for this change

unfortunately still needs me to manually roll back the mesa version
from 20.0.2 (or 20.0.4) to 19.3.3 as discussed in
https://discourse.nixos.org/t/glx-not-recognised-after-mesa-update/6753

using 'sweethome3.application'

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
sweethome3d: 6.2 -> 6.3
03c76d4 
unfortunately still needs me to manually roll back the mesa version
from 20.0.2 (or 20.0.4) to 19.3.3 as discussed in
https://discourse.nixos.org/t/glx-not-recognised-after-mesa-update/6753

using 'sweethome3.application'
@ofborg ofborg bot requested a review from edwtjo April 18, 2020 17:29
@aanderse
Copy link
Member

aanderse commented May 3, 2020

@raboof so is this WIP, waiting on some fixes in mesa?

@raboof
Copy link
Member Author

raboof commented May 3, 2020

@aanderse it's 'equally broken' for me on 6.2 and 6.3, so I'd say the update and the mesa problem are independent

aanderse
aanderse reviewed May 3, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging based on the good word of @raboof 👍
Thanks @raboof 🎉

@aanderse
Copy link
Member

aanderse commented May 3, 2020

@GrahamcOfBorg build sweethome3d

@aanderse aanderse merged commit 7968393 into NixOS:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @aanderse