Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdftools.pdfposter init at 0.7.post1 #82926

Merged
merged 6 commits into from Apr 18, 2020
Merged

pdftools.pdfposter init at 0.7.post1 #82926

merged 6 commits into from Apr 18, 2020

Conversation

wamserma
Copy link
Member

Motivation for this change

pdfposter is packaged for other distriutions and easy enough to package for NixOS so I can maintain it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
pdftools.pdfposter init at 0.7.post1
039fd36 
Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
@wamserma
add myself (wamserma) to maintainer list
7c239f9 
Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
symphorien
symphorien reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compiled and ran successfully the tool on a random pdf.

Apart from the stylistic comment above, this PR looks good.

pkgs/development/python-modules/pdfposter/default.nix Outdated Show resolved Hide resolved
@wamserma
Copy link
Member Author

@FRidh @jonringer could you please have a look?

@veprbl
Copy link
Member

veprbl commented Apr 18, 2020

@GrahamcOfBorg build python27Packages.pdfposter
@GrahamcOfBorg build python37Packages.pdfposter
@GrahamcOfBorg build python38Packages.pdfposter

@veprbl veprbl merged commit 5fbab6d into NixOS:master Apr 18, 2020
@wamserma wamserma deleted the init-pdfposter branch April 18, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@symphorien symphorien symphorien approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @veprbl @symphorien