Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotifyd: add withMpris and withKeyring optionals #85471

Merged
merged 1 commit into from Apr 19, 2020
Merged

spotifyd: add withMpris and withKeyring optionals #85471

merged 1 commit into from Apr 19, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 18, 2020

Motivation for this change
Things done

I tested mpris with playerctl -l and the keyring with secret-tool store --label='name you choose' application rust-keyring service spotifyd username <your-username>.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maxdeviant
Copy link

@bbigras Was just about to do this myself 😄

@bbigras
Copy link
Contributor Author

bbigras commented Apr 19, 2020

cc @anderslundstedt @maxdeviant @marsam

@marsam marsam merged commit ad4eebc into NixOS:master Apr 19, 2020
@bbigras bbigras deleted the spotifyd branch April 19, 2020 12:44
@bbigras
Copy link
Contributor Author

bbigras commented Apr 19, 2020

Thanks for the merge.

For people wanting to try the mpris feature, note that spotifyd currently doesn't emit anything on dbus yet if the state/current song changes. Spotifyd/spotifyd#457

I'm working on a PR.

@maxdeviant
Copy link

I appreciate your work on this, @bbigras!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @maxdeviant @marsam