[RFC] libstore: remove static initialisation #3511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes problems when static linking where static functions are discarded if no other symbol is pulled from the object file.
|
@edolstra can answer for sure, but I think this is how plugins are registered in Nix. |
|
Right, this breaks plugins. |
|
@edolstra Could you please elobrate how this break plugins? If you take a look at my version, I kept the old API in place and only made in-tree stores non-static. |
matthewbauer
approved these changes
May 6, 2020
|
It's also much uglier. The current approach is much cleaner since it doesn't require all store implementations to be enumerated in a global header file. |
|
The implementation can be moved to its own compilation unit if necessary. |
|
#2698 is less intrusive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is is an alternative approach to #2698
If you prefer this approach than I would go ahead and remove the other static intializers as well