Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nixpkgs-19.09]: neomutt: 20180716 -> 2019-10-25 #85434

Closed
wants to merge 2 commits into from
Closed

[nixpkgs-19.09]: neomutt: 20180716 -> 2019-10-25 #85434

wants to merge 2 commits into from

Conversation

matthiasbeyer
Copy link
Contributor

I propose to backport this patch to stable, reason see below.

This does not build yet on my machine because two unit-tests fail. I am about to investigate.

Backported to stable to fix:

https://github.com/neomutt/neomutt/issues/1373

which includes the following patch:

https://github.com/Austin-Ray/neomutt/commit/46eb0a5f275041fc92c2772afd0fd812bae891bd

but the patch itself does not apply cleanly to 20180716, thus we need to
update neomutt.

https://github.com/neomutt/neomutt/releases/tag/2019-10-25
(cherry picked from commit b83908f)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 @matthiasbeyer
neomutt: 20180716 -> 2019-10-25
1610f85 
Backported to stable to fix:

    neomutt/neomutt#1373

which includes the following patch:

    Austin-Ray/neomutt@46eb0a5

but the patch itself does not apply cleanly to 20180716, thus we need to
update neomutt.

https://github.com/neomutt/neomutt/releases/tag/2019-10-25
(cherry picked from commit b83908f)
@matthiasbeyer
Copy link
Contributor Author

@GrahamcOfBorg build neomutt

@matthiasbeyer
Copy link
Contributor Author

I guess this is highly controversial. Thus I wouldn't be offended at all if this gets rejected.

In this case I just take neomutt from unstable. 😄

@Mic92 Mic92 requested a review from flokli April 17, 2020 10:36
Ma27
Ma27 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't backport back then since I was too afraid of breaking too much stuff for other neomutt-users, but if this fixes problematic issues, I'm fine with backporting (I'm usually using neomutt from nixpkgs-unstable).

@matthiasbeyer
Copy link
Contributor Author

Well, I don't know if this breaks other things. As there are no stable releases of neomutt, is think so... Thankfully it is not up to me to decide this.

@flokli
Copy link
Contributor

flokli commented Apr 18, 2020 •
edited

I'm afraid of unexpectedly breaking users of the stable release channel by just bumping the version.

Ran myself into an issue where I didn't see the virtual folders anymore until I had migrated to the named-mailboxes syntax.

I didn't bisect if this specific issue is caused somewhere between these two versions or elesewhere, but it's a general problem as neomutt has no stable releases.
Users can expect some breakage here when upgrading to a new NixOS release, but I don't really want to break during a stable cycle.

I'd be fine with a backport of the specific commit, but given it's nontrivial, and 20.03 is around the corner (with a version more recent than 2019-10-25), I'd propose just using neomutt from unstable/20.03 in the meantime.

@flokli flokli closed this Apr 18, 2020
@matthiasbeyer matthiasbeyer deleted the stable-19.09-fix-neomutt branch April 19, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@erikryb erikryb Awaiting requested review from erikryb

@cstrahan cstrahan Awaiting requested review from cstrahan

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

@vrthra vrthra Awaiting requested review from vrthra

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @flokli @Ma27