-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A more stable angular momentum correction. #2533
A more stable angular momentum correction. #2533
Conversation
@@ -195,5 +195,29 @@ XYZ __cdecl principia__VesselVelocity(Plugin const* const plugin, | |||
return m.Return(ToXYZ(plugin->VesselVelocity(vessel_guid))); | |||
} | |||
|
|||
void __cdecl principia__SetAngularMomentumConservation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an issue to clean up these interfaces method as well as the static state in PileUp
, listing all the stuff that needs to be removed. Once we are satisfied with the fix, we want an easy way to remove the traces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ksp_plugin/pile_up.cpp
Outdated
actual_equivalent_angular_velocity, | ||
actual_pile_up_equivalent_rotation.Forget<OrthogonalMap>()), | ||
correct_angular_velocity ? actual_equivalent_angular_velocity | ||
: NonRotatingPileUp::nonrotating, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
<< actual_equivalent_angular_velocity.Norm() / | ||
(2 * π * Radian / quantities::si::Minute) | ||
<< " rpm\n" | ||
<< (correcting_orientation ? "CORRECTING ORIENTATION" : u8"—"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to yell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES
Tested the binaries in KSP v1.8.1 in a mess of an RP-1 career/dev mod environment. Thanks to egg for providing them. Results: https://gfycat.com/jubilantmeaslydartfrog Report:
|
This appears to significantly improve the behaviour reported in #2519.
It is not perfect. In the save from #2519 (comment), while we get no uncontrolled spin-up, we get more oscillations than in stock, slowing the rocket down, so that it reaches the water without burning up.
Note that this adds back some traces and toggles for debugging. They will be hidden in a separate pull request (but I would like to keep the plumbing around for now; we may not be quite done with this issue yet).