Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up rotation traces #2535

Closed
eggrobin opened this issue Apr 17, 2020 · 0 comments · Fixed by #2780
Closed

Clean up rotation traces #2535

eggrobin opened this issue Apr 17, 2020 · 0 comments · Fixed by #2780
Labels

Comments

@eggrobin
Copy link
Member

In order to investigate #2519, #2533 introduces two interface functions to extract traces from the pile up and switch between experimental behaviours in-game.

Once we have sorted this out (which may take a while, the behaviour in #2533 still has some issues), the interface functions SetAngularMomentumConservation, VesselGetPileUpTrace, and the static boolean members correct_orientation, correct_angular_velocity, and thresholding of PileUp and PrincipiaPluginAdapter should be removed, and any usages of the booleans should be replaced by their default values and simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant