Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: use llvm 10 exclusively #85445

Merged
merged 5 commits into from May 7, 2020
Merged

crystal: use llvm 10 exclusively #85445

merged 5 commits into from May 7, 2020

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Apr 17, 2020 •
edited

Motivation for this change

This is trying to fix build failures on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@manveru manveru marked this pull request as draft April 17, 2020 14:54
@ofborg ofborg bot requested review from david50407 and peterhoeg April 17, 2020 15:11
@manveru manveru marked this pull request as ready for review April 18, 2020 20:27
@manveru
Copy link
Contributor Author

manveru commented Apr 18, 2020

So far this has been working well for me, Ideally I'd always like to use the latest version of LLVM, but there's no good alias available.
For now we can update it manually (if I don't forget about it).

Since we always depend on LLVM anyway, I don't think we should use a different stdenv at all.

@peterhoeg

peterhoeg
peterhoeg reviewed Apr 19, 2020
View reviewed changes
pkgs/development/compilers/crystal/default.nix
@@ -108,6 +108,8 @@ let
"all" "docs"
];

LLVM_CONFIG = "${llvm}/bin/llvm-config";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is necessary? Crystal should be handling this for us.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, but we still need it for the old versions. Doh.

@ofborg ofborg bot requested a review from peterhoeg April 20, 2020 15:07
@peterhoeg
Copy link
Member

peterhoeg commented Apr 22, 2020 •
edited

I cannot help with the testing on mac but when #83054 lands, it'll be easy to check all the dependents on linux at least.

@manveru
Copy link
Contributor Author

manveru commented Apr 23, 2020

@peterhoeg i have access to a few macs for testing this, and it seems perfectly fine so far. Wonder if we can whitelist aarch64 as well now :)

@peterhoeg
Copy link
Member

peterhoeg commented Apr 23, 2020 via email

@grahamc grahamc merged commit fb587d7 into NixOS:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david50407 david50407 Awaiting requested review from david50407

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @peterhoeg @grahamc