Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers: add wamserma #85481

Merged
merged 1 commit into from Apr 18, 2020
Merged

maintainers: add wamserma #85481

merged 1 commit into from Apr 18, 2020

Conversation

wamserma
Copy link
Member

Motivation for this change

Backport to allow better testing of new packages against stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
maintainers: add wamserma
7ab8132 
Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
@wamserma
Copy link
Member Author

@veprbl, please also review/merge. This is a cherry-pick of the commit merged with #85466

@bhipple bhipple merged commit 7fcae37 into NixOS:release-20.03 Apr 18, 2020
@wamserma wamserma deleted the maintainers-add-wamserma-2003 branch April 18, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wamserma @bhipple