-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teams: fixing pulseaudio access #85451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I would be interested to know why prepending pulseaudio (and systemd) to runpath fixes the problem? Those are the first entries in RUNPATH
of bin/teams
already (per readelf -d
).
I do not know why it works, but for me it fixed it. I'm not sure it's the cleanest solution. I used |
Using |
I think I may have found a solution that doesn’t involve changing The Adding @elyhaka can you test removing the dontAutoPatchelf = true;
# Include runtimeDependencies in the RPATH of the included Node modules
# so that dynamic loading works. See: https://github.com/NixOS/nixpkgs/issues/85449
postFixup = ''
autoPatchelf "$out"
runtime_rpath="${lib.makeLibraryPath runtimeDependencies}"
for mod in $(find "$out/opt/teams" -name '*.node'); do
mod_rpath="$(patchelf --print-rpath "$mod")"
echo "Adding runtime dependencies to RPATH of Node module $mod"
patchelf --set-rpath "$runtime_rpath:$mod_rpath" "$mod"
done;
''; |
If fixes the issue indeed ! @liff : Do you want me to update my PR with this fix or you want to open another one ? (EDIT: sorry for the miss click on "Close" while responding... 🙄) |
Updating your PR should be fine, thanks. |
Done ! Maybe this fix should be backported to 20.03 ? |
Is there anything still blocking this PR ? :) |
pkgs/applications/networking/instant-messengers/teams/default.nix
Outdated
Show resolved
Hide resolved
Result of 1 package built:- teams |
Is a backport required? |
I believe this issue also exists on 20.03, I'm not sure to be honest ? Is there an easy way to try without switching my whole system to 20.03 ? |
|
Thank you for the command ! Without this commit I do reproduce the issue on the 20.03. |
Backport: |
Motivation for this change
I've discovered an issue with Microsoft Teams, related to audio quality. Wrapping it with a LD_LIBRARY_PATH fixes #85449 for me.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)