Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Get rid of -dumpmachine in favor of static info #85468

Merged
merged 1 commit into from Apr 18, 2020
Merged

treewide: Get rid of -dumpmachine in favor of static info #85468

merged 1 commit into from Apr 18, 2020

Conversation

Ericson2314
Copy link
Member

Motivation for this change

https://github.com/NixOS/nixpkgs/pull/84531/files#diff-3e4b92056be5feba77b1863ad5bbd91e gave me the idea. First commit of #85189 as that is hard to test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 changed the base branch from master to staging April 17, 2020 23:00
lovesegfault
lovesegfault approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Ericson2314 Ericson2314 changed the base branch from staging to master April 18, 2020 04:24
@ofborg ofborg bot requested a review from lovesegfault April 18, 2020 04:30
@Ericson2314 Ericson2314 merged commit eb4acb6 into NixOS:master Apr 18, 2020
@Ericson2314 Ericson2314 deleted the no-dumpmachine branch April 18, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco Awaiting requested review from davidtwco

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @lovesegfault