New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: dockerize this repository and make sure that it can run on AWS #8
Conversation
This involves a lot of small changes: - Add sentry support - Add GitHub Actions auto-deployment - Add Dockerfile - Patch werkzeug to only log non-2NN/3NN - Readme full of badges
github-token: ${{ secrets.DEPLOYMENT_TOKEN }} | ||
state: success | ||
description: "Successfully deployed ${{ github.event.deployment.payload.version }} on ${{ github.event.deployment.environment }}" | ||
url: "https://bananas.staging.openttd.org/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the staging url be hardcoded like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, yes. This is true for all repositories for now (has been in website for a while now). I should fix it some day ..
In GitHub, this URL is also not shown in any place atm. So maybe a proper solution is to remove it everywhere.
Anyway, not an issue for now, I think :D (let me know if you disagree)
This pull request introduces 4 alerts when merging 6df67de into 8feedf0 - view on LGTM.com new alerts:
|
For Python3, LGTM is kinda wrong. You really have to fuck up on multiple levels before this is an issue. Anyway, I do want to address the issue, but in a different form. I want to make some OpenTTD python packages with some common code. This file for example, is now in 4 repositories. Same for So for now I am going to ignore the LGTM feedback. Mainly as we have a deadline to make :D |
This pull request introduces 4 alerts when merging ba2e37f into 8feedf0 - view on LGTM.com new alerts:
|
This pull request introduces 8 alerts when merging be13bfd into 8feedf0 - view on LGTM.com new alerts:
|
This involves a lot of small changes: